[coreboot-gerrit] Change in ...coreboot[master]: nb/via/vx900: Use 64 bits to prevent overflow

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32291 )

Change subject: nb/via/vx900: Use 64 bits to prevent overflow
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32291/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32291/1//COMMIT_MSG@9 
PS1, Line 9: The bit operations are currently done using 32 bit math.
           : Cast the first argument to 64 bits to prevent possible
           : overflow.
Does this fix anything? If the 32 bit math overflows you'd certainly still have problems with that cast. IMO it would make more sense to check for the sanity of the memory space sizes.