[coreboot-gerrit] [L] Change in coreboot[main]: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)

[Ronald Claveau (Code Review)]

Attention is currently required from: Nicholas Chin.

Ronald Claveau has posted comments on this change by Ronald Claveau. ( https://review.coreboot.org/c/coreboot/+/83104?usp=email )

Change subject: mainboard/dell: Add new mainboard XPS 8300 (Sandy Bridge)
......................................................................

Patch Set 16:

(1 comment)

File src/mainboard/dell/xps_8300/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/83104/comment/aad642bb_2bb763a5?usp... :
PS16, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
            : 
            : /*#undef SIO_ENABLE_FDC0		// pnp 2e.0: Disable Floppy Controller
            : #undef SIO_ENABLE_INFR		// pnp 2e.a: Disable Consumer IR
            : 
            : #undef SIO_ENABLE_PS2K		// pnp 2e.5: Disable PS/2 Keyboard
            : #undef SIO_ENABLE_PS2M		// pnp 2e.6: Disable PS/2 Mouse
            : #define SIO_ENABLE_COM1		// pnp 2e.1: Enable Serial Port 1
            : #define SIO_ENABLE_ENVC         // pnp 2e.4: Enable Environmental Controller
            : #define SIO_ENVC_IO0      0x0a	// pnp 2e.4: io 0x60
            : #define SIO_ENVC_IO1      0x0a	// pnp 2e.4: io 0x62
            : #define SIO_ENABLE_GPIO		// pnp 2e.7: Enable GPIO
            : #define SIO_GPIO_IO0      0x0a	// pnp 2e.7: io 0x60
            : #define SIO_GPIO_IO1      0x0a	// pnp 2e.7: io 0x62
            : 
            : #i
> The whole content is commented out. Is it even needed? Maybe replace with my suggestion. […]

Fix applied.