Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45458 )
Change subject: mb/google/dedede: Enable I2C5 pads ......................................................................
Patch Set 1:
(2 comments)
I just learned from Will that I2C5 may not be the final plan. Maybe I should just shelve this change until there's a non-reference board that actually needs it.
https://review.coreboot.org/c/coreboot/+/45458/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45458/1//COMMIT_MSG@9 PS1, Line 9: Waddledee
Nit: Waddledee -> Dedede
Wait did Doo change too? The sentence was trying to convey that one specific variant needs it (even though we're turning it on generically).
https://review.coreboot.org/c/coreboot/+/45458/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/45458/1/src/mainboard/google/dedede... PS1, Line 187: AP_I2C_SUB_SDA
Nit: AP_I2C_SUB_SDA/AP_I2C_CAM_SDA. Same for SCL.
Will told me that in the event they do adopt I2C5 as the final solution, they likely wouldn't rename the nets in the schematic. Do you still want me to rename?