Attention is currently required from: Martin L Roth, Subrata Banik, Caveh Jalali, Nick Vaccaro, Elyes Haouas, Boris Mittelberg.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72639 )
Change subject: ec/google/chromeec: clang-format ec_commands.h
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72639/comment/63041173_a40c6b50
PS1, Line 14: future updates don't get overwhelmed
: by inconsequential style changes
either way, we need to run this file once through clang-format - either with […]
Thanks. Now I think this is better because CB:72640 becomes a pure sync from EC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbd6d00922dc5fd4c44ee109d54cea612e15db06
Gerrit-Change-Number: 72639
Gerrit-PatchSet: 3
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Tue, 07 Feb 2023 02:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment