Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Jingle Hsu, Shuming Chu (Shuming), Arthur Heymans.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69363 )
Change subject: soc/intel/xeon_sp: Move SMBIOS type 4 override functions from mainboard to soc
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/xeon_sp/ramstage.c:
https://review.coreboot.org/c/coreboot/+/69363/comment/85ad8fc4_d385feca
PS1, Line 3: <arch/cpu.h>
maybe use <cpu/cpu.h> instead of <arch/cpu.h> ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69363
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17df8de67bc2f5e89ea04da36efb2480a7e73174
Gerrit-Change-Number: 69363
Gerrit-PatchSet: 1
Gerrit-Owner: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 08 Nov 2022 12:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment