10 Dec
2018
10 Dec
'18
2:08 p.m.
uwe poeche has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30128 )
Change subject: siemens/mc_apl4: Add GPIO configuration ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30128/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c:
https://review.coreboot.org/#/c/30128/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 80:
One blank line is enough.
Done
https://review.coreboot.org/#/c/30128/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 358: TB
blank character
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/30128
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia69603f42c57c1cc682550b8eeeab42fbac27563
Gerrit-Change-Number: 30128
Gerrit-PatchSet: 2
Gerrit-Owner: uwe poeche uwe.poeche@siemens.com
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: uwe poeche uwe.poeche@siemens.com
Gerrit-Comment-Date: Mon, 10 Dec 2018 14:08:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-MessageType: comment