V Sowmya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84420?usp=email )
Change subject: mb/google/nissa/var/nivviks: Update the power resource for NVM and VCM ......................................................................
mb/google/nissa/var/nivviks: Update the power resource for NVM and VCM
The earlier changes pushed to resolve the camera LED blinking issue led to the regressions with camera autofocus functionality. This change updates the power resource for NVM and VCM to fix the issue.
BUG=b:365899407 TEST=Build and boot tivviks. Verified the Autofocus and all the camera sanity tests.
Change-Id: Id3e256d59982ac176844e289f18ee450079704b9 Signed-off-by: Sowmya V v.sowmya@intel.com --- M src/mainboard/google/brya/variants/nivviks/overridetree.cb 1 file changed, 19 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/84420/1
diff --git a/src/mainboard/google/brya/variants/nivviks/overridetree.cb b/src/mainboard/google/brya/variants/nivviks/overridetree.cb index 67c47346..c156d2a 100644 --- a/src/mainboard/google/brya/variants/nivviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/nivviks/overridetree.cb @@ -437,14 +437,17 @@
# Controls register "gpio_panel.gpio[0].gpio_num" = "GPP_D15" # EN_PP2800_WCAM_X + register "gpio_panel.gpio[1].gpio_num" = "GPP_D16" # EN_PP1800_PP1200_WCAM_X
# _ON - register "on_seq.ops_cnt" = "1" + register "on_seq.ops_cnt" = "2" register "on_seq.ops[0]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" + register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(1, 5)"
# _OFF - register "off_seq.ops_cnt" = "1" - register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" + register "off_seq.ops_cnt" = "2" + register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" + register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(0, 0)"
device i2c 0C on probe WFC WFC_MIPI_OVTI5675 @@ -456,6 +459,19 @@ register "acpi_name" = ""NVM0"" register "chip_name" = ""GT24C08"" register "device_type" = "INTEL_ACPI_CAMERA_NVM" + register "has_power_resource" = "1" + register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD" + + # Controls + register "gpio_panel.gpio[0].gpio_num" = "GPP_D16" # EN_PP1800_PP1200_WCAM_X + + # _ON + register "on_seq.ops_cnt" = "1" + register "on_seq.ops[0]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" + + # _OFF + register "off_seq.ops_cnt" = "1" + register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(0, 0)"
register "nvm_size" = "0x2000" register "nvm_pagesize" = "1" @@ -509,12 +525,6 @@ register "sdmode_delay" = "5" device generic 0 on end end - chip drivers/sof - register "spkr_tplg" = "max98360a" - register "jack_tplg" = "nau8825" - register "mic_tplg" = "_2ch_pdm0" - device generic 0 on end - end end device ref pcie_rp4 on probe WIFI_CATEGORY WIFI_7