HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41348 )
Change subject: soc/intel/xeon_sp/cpx: display UPDs and CPX-SP specific HOBs
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41348/12/src/soc/intel/xeon_sp/cpx/...
File src/soc/intel/xeon_sp/cpx/hob_display.c:
https://review.coreboot.org/c/coreboot/+/41348/12/src/soc/intel/xeon_sp/cpx/...
PS12, Line 2:
: #include <console/console.h>
: #include <fsp/util.h>
: #include <lib.h>
: #include <assert.h>
: #include <hob_iiouds.h>
: #include <hob_memmap.h>
: #include <soc/soc_util.h>
would you please include only what you use ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41348
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42dd519103cc604d4cfee858f4774bd73c979e77
Gerrit-Change-Number: 41348
Gerrit-PatchSet: 12
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jun 2020 06:29:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment