Attention is currently required from: Furquan Shaikh, Martin Roth, Duncan Laurie. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52747 )
Change subject: util/sconfig: Add support for discontiguous FW_CONFIG fields ......................................................................
Patch Set 1:
(45 comments)
File util/sconfig/lex.yy.c_shipped:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/75068368_eb8bbe39 PS1, Line 34: * if you want the limit (max/min) macros for int types. trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/f26a117c_021ac04e PS1, Line 51: typedef unsigned char flex_uint8_t; trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/bc60e9ae_9fa41f98 PS1, Line 162: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/5c0d18d5_9e338742 PS1, Line 165: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/0ba9c055_44413420 PS1, Line 641: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/ecd2847c_a7982876 PS1, Line 643: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/4c068ac0_71040341 PS1, Line 770: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/01466be3_96dfd70b PS1, Line 1344: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/55d75906_3babbff2 PS1, Line 1400: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/42045547_6960a4ba PS1, Line 1445: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/84814c72_998e0fbe PS1, Line 1512: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/ca080320_0dba9322 PS1, Line 1517: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/21bb8b2f_0a2264e4 PS1, Line 1530: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/c392614d_fc7bb4c4 PS1, Line 1534: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/e2551b70_ae546fed PS1, Line 1574: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/8e6105ff_f635bdef PS1, Line 1580: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/c5e2f7ae_1c96da81 PS1, Line 1603: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/b38405f3_2975c181 PS1, Line 1607: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/9c490fa4_49bb0907 PS1, Line 1628: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/43a49784_ae23a65c PS1, Line 1644: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/d05a60d9_d70e98ed PS1, Line 1650: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/7f49e7b7_b8299cbe PS1, Line 1679: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/73d94d9d_12eb564e PS1, Line 1709: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/57ca5507_781550b2 PS1, Line 1733: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/a3d7c154_fef6045f PS1, Line 1776: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/e967a71b_81119cdf PS1, Line 1782: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/e8d858ea_4f8a83ae PS1, Line 1811: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/075c3023_312b90a0 PS1, Line 1818: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/b1da427e_c2da9e33 PS1, Line 1826: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/69e99744_5eaec881 PS1, Line 1835: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/b0d0f209_6644f837 PS1, Line 1889: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/75dfd59a_6a804842 PS1, Line 1893: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/d2fce9ef_37b5463b PS1, Line 1898: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/8ea7f9ba_cf1d894f PS1, Line 1906: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/e0a4ba7b_441cbaa0 PS1, Line 1914: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/f83bf294_1998b32e PS1, Line 1922: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/b612e68f_149f4d70 PS1, Line 1932: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/5d1c2852_fb4257b0 PS1, Line 1936: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/42a2851e_868fc42f PS1, Line 1943: * trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/a4c9ec8a_333c1e6c PS1, Line 1997: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/2197496c_44b3d8d8 PS1, Line 2023: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/2bb5d276_0e2990a7 PS1, Line 2048: trailing whitespace
File util/sconfig/main.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/e4e7a707_547fe5e7 PS1, Line 453: printf("ERROR: fw_config field %s has invalid range %u-%u\n", field->name, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/5e017bf0_8c566cc8 PS1, Line 598: uint64_t orig_mask = ((1ull << (1ull + bits->end_bit - bits->start_bit)) - 1ull); line over 96 characters
File util/sconfig/sconfig.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118035): https://review.coreboot.org/c/coreboot/+/52747/comment/99a61b18_19a26212 PS1, Line 223: struct fw_config_field *new_fw_config_field(const char *name, struct fw_config_field_bits *bits); line over 96 characters