Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37662 )
Change subject: soc/intel/{icl,cnl,tgl}: Always add PM1_TMR block to FADT
......................................................................
Patch Set 1:
Please add the explanation in the commit message as inline comment as well, to make sure everyone looking at the code understands how it works.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3d592623f3a84051477ffe83a0cf0daf30dd36f
Gerrit-Change-Number: 37662
Gerrit-PatchSet: 1
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 12 Dec 2019 06:17:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment