Attention is currently required from: Amanda Hwang.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46643 )
Change subject: mb/google/octopus/var/fleex: Add new SKU for LTE touch
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/46643/comment/4f226a92_b685cd97
PS4, Line 12: return (google_chromeec_get_board_sku() >= MIN_LTE_SKU);
* Note that fleex variant supports not only Fleex but also grabbiter and orbatrix which SKU IDs are all bigger than 4. As a result, the CL here caused SRA table is not loaded for grabbiter and orbatrix.
* b/181946744 is created for this issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0405d3e52aa813bbb1f350966a9e2825e595ce4
Gerrit-Change-Number: 46643
Gerrit-PatchSet: 4
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 05 Mar 2021 11:50:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment