Attention is currently required from: Arthur Heymans, David Hendricks, Jincheng Li, Jonathan Zhang, Lean Sheng Tan, Nicholas Chin, Patrick Rudolph, Paul Menzel, TangYiwei, Varshit Pandya.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81319?usp=email )
Change subject: mb/intel/avenuecity_crb: Add 2S GNR/SRF-AP server board Avenue City
......................................................................
Patch Set 34:
(1 comment)
File src/mainboard/intel/avenuecity_crb/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81319/comment/e5e27060_25945405 :
PS34, Line 23: io 0x60 = 0x3f8 # PNP_IDX_IO0
it would be good if we could change this to CONFIG_TTYS0_BASE as well, but there will be error reported during the build process,
line 23: CONFIG_TTYS0_BASE: syntax error
Makefile.mk:710: recipe for target 'build/mainboard/intel/avenuecity_crb/static.c' failed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81319?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64fdd5388aadf7732f6d3daa600c1455d3672a46
Gerrit-Change-Number: 81319
Gerrit-PatchSet: 34
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen, Gang C
gang.c.chen@intel.com
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Wed, 10 Apr 2024 12:01:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment