Attention is currently required from: Jason Nien, Matt DeVillier.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69454 )
Change subject: mb/google/zork: Move PCIe GPIO config from bootblock to romstage
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
These have been painstakingly configured to allow the correct amount of time for the wifi and wwan devices to be brought up meeting their timing parameters.
I don't think moving these just for the sake of moving them is a good idea at all.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69454
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I609b9a8bd78587b60c0cf1ef14feda88ad3bb4a2
Gerrit-Change-Number: 69454
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 11 Nov 2022 21:39:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment