Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31285 )
Change subject: mb/intel/../../cml_u: Override LPSS related FSP UPD for CMLRVP
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31285/2/src/mainboard/intel/coffeelake_rvp/K...
File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/31285/2/src/mainboard/intel/coffeelake_rvp/K...
PS2, Line 25: OVERRIDE_DEVICETREE
The devicetree configured currently in Kconfig is variant specific. […]
Ideally this board should be used with CML SoC, since we do not have the SoC yet we will use the WHL SoC. Since there are differences in the FSP UPDs between CML and CNL and that has a bearing on the devicetree.cb depending upon the SoC used this was added to isolation. Once we have the CML SoC available we will select the CML specific config and this devicetree along with related FSP UPD changes should get picked.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31285
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82e3323df952762e2d9c14f1e3cfa75872ccc9b4
Gerrit-Change-Number: 31285
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 13 Feb 2019 10:13:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment