Attention is currently required from: Jamie Ryu, Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Angel Pons, Nick Vaccaro, Michael Niewöhner, Tim Wawrzynczak. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63170 )
Change subject: intel/common/block: Add gpmr common driver ......................................................................
Patch Set 14:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63170/comment/938da2aa_09a25d07 PS14, Line 9: Move GPMR(General Purpose Memory Range) APIs to gpmr driver from dmi.c : For this, 3 patches are used. : 1. Add GPMR common driver in IA common code(CB:63170) : 2. Migrate all DMI API usage to GPMR(CB:63471) : 3. Drop DMI driver (CB:63472) :
hmm, it seems the newly added code for the gpmr driver is ~90% identical to the dmi driver. Why not rename the dmi driver, then refactor/clean it up, instead of adding a modified copy and delete the origin? This would make it easier to keep track of the changes.
I guess I'm the one who suggested to add a new GPMR common driver and clear up the SoC code in two separate CL, the reason that I have in mind is better code readability, otherwise same Cl is renaming APIs, changing Kconfig depex across SoC and rest of the IA common code. Hence, ideally I thought we could add a new driver (in commit msg, we could mention that it's derived from DMI common code) and next CL is to touch only SoC code to utilise the GPMR common code instead DMI. And finally drop the unused DMI driver (after SoC starts referring to GPMR).