Attention is currently required from: David Wu, Krishna P Bhat D, Reka Norman, Reka Norman, Stefan Reinauer, Subrata Banik.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81928?usp=email )
Change subject: util/ifdtool: Add support for checking GPR0 status
......................................................................
Patch Set 5:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/81928/comment/07cc8efa_56162b11 :
PS4, Line 1802: reg.data.write_protect_en
Yes, that's what I meant. My point is that just because the enable bit is set, it doesn't necessarily mean protection is enabled. E.g. if the range is 0, it's not really enabled.
I'm agree with you. Since the purpose of `is_gpr0_protected()` is to know GPR0 protected is enabled/disabled, so check whole register should be safer.
I will try to do it in `is_gpr0_protected()`, will update once I complete.
Can I ask what you're planning to use this for? Is it just for developers to use locally, or are you planning to use it in some automated process / test?
It's for developers to use.
Thank you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81928?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b3af973be784200b965a68e5f6b7737cba03ed7
Gerrit-Change-Number: 81928
Gerrit-PatchSet: 5
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Thu, 18 Apr 2024 02:38:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-MessageType: comment