Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F ......................................................................
Patch Set 60:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... PS60, Line 18: Scope (_SB) { : Device (PCI0) {
You are always complaining about this - but this throws an error when comping the asl code ;)
Uh, weird. It works for me on other platforms
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/memory.c:
https://review.coreboot.org/c/coreboot/+/37441/60/src/mainboard/supermicro/x... PS60, Line 27: .rcomp_resistor = {121, 81, 100},
These values often go through me and come from Intel doc #573387. […]
I usually dig the resistor values from schematics for ULT and Halo, and then ask Nico if they are correct. They usually are the same for SKL and CFL parts with the same topology (CFL is just SKL refresh refresh).
On socketed platforms, however, the resistors are under the CPU [1]. One day on IRC, Nico and I were curious about the value of those resistors, so I took a dead i5-6400 and desoldered the resistors to measure the values. And the resistor values matched those for Halo: 121, 75, 100.
[1]: https://i.imgur.com/YMdxMWf.jpg (The three light blue components on the top left corner of the center are those RCOMP resistors)