Attention is currently required from: Hung-Te Lin, Yidi Lin.
Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/85598?usp=email )
Change subject: util/mtkheader: Add GFH header for mt8189 bootblock code
......................................................................
Patch Set 1:
(1 comment)
File util/mtkheader/gen-bl-img.py:
https://review.coreboot.org/c/coreboot/+/85598/comment/179b636b_0e7405d0?usp... :
PS1, Line 27: 'mt8189': 0x02001000,
: 'mt8196': 0x02001000,
can we reuse mt8196's entry ?
I don't think reuse mt8196's entry would be a good idea, as it would mean we need to rewrite src/soc/mediatek/mt8189/Makefile.mk as follows:
```
./util/mtkheader/gen-bl-img.py mt8196 sf $< $@
```
Although the result is the same, it doesn't make sense in terms of readability.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85598?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I47078272880a89e81c851ede307cdc306b1c79ac
Gerrit-Change-Number: 85598
Gerrit-PatchSet: 1
Gerrit-Owner: Vince Liu
vince-wl.liu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Mon, 16 Dec 2024 01:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com