Attention is currently required from: Tim Wawrzynczak, Won Chung, Angel Pons, Nick Vaccaro, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61803 )
Change subject: mb/google/var/agah: Use ACPI _PLD macro
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
If in the panel left/right the second description should be rear/mid/front;If in the panel rear/front the second description should be left/mid/right. Will this be more intuitive? This description is user faces.
IMO, having panel and horizontal configurable can still provide the flexibility rather adding more macro. We could add specific macro, but I felt https://review.coreboot.org/c/coreboot/+/61801/3/src/include/acpi/acpi_pld.h is reasonable for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61803
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb8f30b2d1069aea1d5ce7c5dda7f99de33a7c26
Gerrit-Change-Number: 61803
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Won Chung
wonchung@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Won Chung
wonchung@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Feb 2022 16:55:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment