Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31442 )
Change subject: soc/intel/cannonlake: select VMX configurabiltity
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31442/2/src/soc/intel/cannonlake/cpu.c
File src/soc/intel/cannonlake/cpu.c:
https://review.coreboot.org/#/c/31442/2/src/soc/intel/cannonlake/cpu.c@464
PS2, Line 464: mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC);
: }
could you explain in the commit message and here in the code why this is run here and not simply during cpu_driver ops? Also why is the wheel reinvented with vmx_configure in soc/intel while there has been code that does the more or less the same in cpu/intel/common?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9a49deb52e33c1c400a7e2cfab6337b62ecc08e
Gerrit-Change-Number: 31442
Gerrit-PatchSet: 2
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 16 Feb 2019 11:52:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment