Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44734 )
Change subject: Revert "cpu/x86/sipi: Add x86_64 support"
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44734/1/src/cpu/x86/Makefile.inc
File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44734/1/src/cpu/x86/Makefile.inc@a2...
PS1, Line 27: rmodules_$(ARCH-$(TARGET_STAGE)-y)-generic-ccopts += $($(TARGET_STAGE)-generic-ccopts)
Ack
I investigated the issue. This line adds -D__RAMSTAGE__ as intended.
src/include/rules.h will then no longer set ENV_RMODULE 1 and remove the parameter section from the linker script.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ideed19437667124a02c0f03aa7be8dec042d0f44
Gerrit-Change-Number: 44734
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Aug 2020 18:18:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment