[coreboot-gerrit] [M] Change in coreboot[master]: arch/x86/smbios.c: Allow creating entries for empty DIMM slots

[Jonathan Zhang (Code Review)]

Attention is currently required from: Arthur Heymans, Marc Jones, Nico Huber, Angel Pons, lichenchen.carl, Shuming Chu (Shuming), Nill Ge.

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64035 )

Change subject: arch/x86/smbios.c: Allow creating entries for empty DIMM slots
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

File src/arch/x86/smbios.c:

https://review.coreboot.org/c/coreboot/+/64035/comment/521857fd_6de66194 
PS1, Line 295: 	t->manufacturer = smbios_add_string(t->eos, "NO DIMM");
             : 	t->serial_number = smbios_add_string(t->eos, "NO DIMM");
             : 	t->asset_tag = smbios_add_string(t->eos, "NO DIMM");
             : 	t->part_number = smbios_add_string(t->eos, "NO DIMM");
> We may want to fill in those fields with empty strings.

Ack