Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41760 )
Change subject: intel/fsp2_0: Add fsp_get_version() to copy FSP version to a char buffer
......................................................................
Patch Set 11:
(2 comments)
I do not see, why this should be configurable by a Kconfig option. I’d always add the FSP version to the coreboot tables.
https://review.coreboot.org/c/coreboot/+/41760/11/src/drivers/intel/fsp2_0/K...
File src/drivers/intel/fsp2_0/Kconfig:
PS11:
The Kconfig addition should probably go into the next commit?
https://review.coreboot.org/c/coreboot/+/41760/11/src/drivers/intel/fsp2_0/K...
PS11, Line 213: cbmem
What does CBMEM have to do with coreboot tables?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I579fa87028b9ed0734b2fac206daf43ecae311be
Gerrit-Change-Number: 41760
Gerrit-PatchSet: 11
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 15 Jun 2020 08:50:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment