Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/25585 )
Change subject: siemens/mc_apl1: Fix for using IDT PMIC ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/25585/1/src/mainboard/siemens/mc_apl1/mainbo... File src/mainboard/siemens/mc_apl1/mainboard.c:
https://review.coreboot.org/#/c/25585/1/src/mainboard/siemens/mc_apl1/mainbo... PS1, Line 146: mdelay(1); is this delay required here? if not, you might be better off by using the stopwatch API from src/include/timer.h: create a stopwatch and use "while (!stopwatch_expired(sw)) ..."