Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48691 )
Change subject: soc/intel/common/block/acpi: Fix get_cores_per_package
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48691/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48691/1//COMMIT_MSG@12
PS1, Line 12: .
because `numcpus` ends up being zero due to integer division truncation.
Done
https://review.coreboot.org/c/coreboot/+/48691/1//COMMIT_MSG@21
PS1, Line 21: HyperThreading disabled.
Maybe mention that this change is based on commit 920d2b77f2
use different function, marking as obsolete
https://review.coreboot.org/c/coreboot/+/48691/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/48691/1/src/soc/intel/common/block/...
PS1, Line 424: get_logical_cores_per_package();
can you reuse cpu_read_topology()?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48691
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9b985a07cd3f99a823622f766c80ff240ac1188
Gerrit-Change-Number: 48691
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Marc Jones
marc.jones@amd.corp-partner.google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Mon, 21 Dec 2020 12:13:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment