Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44510 )
Change subject: Intel GBE 82579LM bincfg set and spec ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Looks pretty good to me, did you test this by comparing what it generated to your actual GbE? If it was identical, we can probably merge this, or if it wasn't identical did you test on hw?
https://review.coreboot.org/c/coreboot/+/44510/2/util/bincfg/Makefile File util/bincfg/Makefile:
https://review.coreboot.org/c/coreboot/+/44510/2/util/bincfg/Makefile@22 PS2, Line 22: # Use this target to generate GbE for X200 This should be X220/X230 instead of X200.