Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33907 )
Change subject: mediatek/mt8183: Calibration RTC eosc clock ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/33907/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33907/2//COMMIT_MSG@7 PS2, Line 7: Calibration Imperative mood: Calibrate
https://review.coreboot.org/#/c/33907/2//COMMIT_MSG@9 PS2, Line 9: go goes
https://review.coreboot.org/#/c/33907/2//COMMIT_MSG@9 PS2, Line 9: Calibration Calibrate
https://review.coreboot.org/#/c/33907/2/src/soc/mediatek/mt8183/rtc.c File src/soc/mediatek/mt8183/rtc.c:
https://review.coreboot.org/#/c/33907/2/src/soc/mediatek/mt8183/rtc.c@204 PS2, Line 204: /* set eosc clock */ Is this comment needed?
https://review.coreboot.org/#/c/33907/2/src/soc/mediatek/mt8183/rtc.c@212 PS2, Line 212: /* eosc32 calibration for powerdown clock */ Calibrate eosc32 for powerdown clock