Attention is currently required from: Jian Tong, Karthik Ramasubramanian, Subrata Banik.
Paul Menzel has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/84177?usp=email )
Change subject: mb/google/brox/var/lotso: disable RTS5227 PCIE L0s support
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84177/comment/a4a9fb2d_af1e7ae7?usp... :
PS3, Line 9: Because of RTS5227 don't support L0s, so set to ASPM_L1.
What is the result of that? Errors in the log? Non-working device?
Then maybe:
According to X the RTS5227 does not support L0s, so set it to ASPM_L1.
https://review.coreboot.org/c/coreboot/+/84177/comment/e42195d3_8656a9de?usp... :
PS3, Line 12: TEST=emerge-brox sys-boot/coreboot sys-boot/chromeos-bootimage
How can the change be verified?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84177?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I87bb0d195566d273951dee6eeb54c9b388dd7607
Gerrit-Change-Number: 84177
Gerrit-PatchSet: 3
Gerrit-Owner: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 04 Sep 2024 18:21:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No