Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43437 )
Change subject: mb/google/zork: Remove redundant PCI info from overridetrees
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43437/5/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43437/5/src/mainboard/google/zork/v...
PS5, Line 43: device pci 1.6 off end # GPP Bridge 5
: device pci 1.7 on end # GPP Bridge 6 - NVME
You will have to now add this to devicetree_trembyle.cb: […]
Right. Are we sure dalboz shouldn't include this too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43437
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c3c1c2410166b99599d7343fae3ee756f4da321
Gerrit-Change-Number: 43437
Gerrit-PatchSet: 5
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jul 2020 19:59:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment