build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39270 )
Change subject: mb/ocp/tiogapass: Add UART init in bootblock ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39270/1/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/bootblock.c:
https://review.coreboot.org/c/coreboot/+/39270/1/src/mainboard/ocp/tiogapass... PS1, Line 38: if (CONFIG(BOOTBLOCK_CONSOLE)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/39270/1/src/soc/intel/xeon_sp/bootb... File src/soc/intel/xeon_sp/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/39270/1/src/soc/intel/xeon_sp/bootb... PS1, Line 61: if (CONFIG(BOOTBLOCK_CONSOLE)) { braces {} are not necessary for single statement blocks