17 Oct
2019
17 Oct
'19
11:53 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36054 )
Change subject: soc/mediatek/mt8183: Compress calibration blob with LZ4 ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36054/2/src/soc/mediatek/mt8183/Mak... File src/soc/mediatek/mt8183/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36054/2/src/soc/mediatek/mt8183/Mak... PS2, Line 87: CBFS_PRERAM_COMPRESS_FLAG nit: could also use CBFS_COMPRESS_FLAG? RAM isn't up yet when you load this, but the important part is whether the LZMA code is compiled into the stage, which is true for romstage.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3bd49d67ee6f80a0e4d8f6945744642611edf64
Gerrit-Change-Number: 36054
Gerrit-PatchSet: 2
Gerrit-Owner: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Ben Ho Ben.Ho@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 17 Oct 2019 23:53:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment