Attention is currently required from: Angel Pons, Subrata Banik, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56217 )
Change subject: mb/intel/coffeelake_rvp: Rework Kconfig ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56217/comment/cb79bbd6_dbfee348 PS3, Line 17: Built each variant with `BUILD_TIMELESS=1` and all generated
I imagine you had to skip including the config file inside the coreboot. […]
Right, I did not include the .config file.
File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/56217/comment/4d78b9a1_b6922368 PS3, Line 15: BOARD_INTEL_COFFEELAKE_RVP8_OPTIONS
I'd reuse the symbols declared in Kconfig. […]
The linter complains about this: Error: BOARD_INTEL_COFFEELAKE_RVP8 entry at src/mainboard/intel/coffeelake_rvp/Kconfig:15 has already been created outside a choice block at src/mainboard/intel/coffeelake_rvp/Kconfig.name:12.