build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61771 )
Change subject: libpayload: Export PCIe config info from coreboot to libpayload ......................................................................
Patch Set 1:
(7 comments)
File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140449): https://review.coreboot.org/c/coreboot/+/61771/comment/a6f8c14d_2ebd2cb2 PS1, Line 159: { CBMEM_ID_PCIE, "PCIE"} please, no space before tabs
File src/lib/coreboot_table.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140449): https://review.coreboot.org/c/coreboot/+/61771/comment/4c1155e7_e8c0d5b1 PS1, Line 101: printk(BIOS_ERR, "CBMEM entry for PCI info missing\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140449): https://review.coreboot.org/c/coreboot/+/61771/comment/904f1864_59707218 PS1, Line 101: printk(BIOS_ERR, "CBMEM entry for PCI info missing\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140449): https://review.coreboot.org/c/coreboot/+/61771/comment/a575ab54_ed9eda7a PS1, Line 102: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140449): https://review.coreboot.org/c/coreboot/+/61771/comment/519e049a_f5692816 PS1, Line 102: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140449): https://review.coreboot.org/c/coreboot/+/61771/comment/ddc1044f_e9849d10 PS1, Line 103: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140449): https://review.coreboot.org/c/coreboot/+/61771/comment/65bce859_fb20c85a PS1, Line 103: } please, no spaces at the start of a line