[coreboot-gerrit] Change in coreboot[master]: security/tpm/crtm.c: Fix !CONFIG_BOOTBLOCK_IN_CBFS measuring

[Nico Huber (Code Review)]

Attention is currently required from: Christian Walter, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64418 )

Change subject: security/tpm/crtm.c: Fix !CONFIG_BOOTBLOCK_IN_CBFS measuring
......................................................................

Patch Set 1:

(1 comment)

File src/security/tpm/tspi/crtm.c:

https://review.coreboot.org/c/coreboot/+/64418/comment/914b88c8_0bc2ddbe 
PS1, Line 74: 	} /* else: TODO: Add SoC specific measurement methods. */
Shouldn't we still return an error? or is this merely a best-effort
measuring? IOW, should people know that the measuring is incomplete?

(TBH, I don't understand self-measuring generally. It wouldn't make a
difference if we'd use a pre-computed hash, would it?)