Attention is currently required from: Tim Wawrzynczak, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49414 )
Change subject: mb/up/squared: do LPC/eSPI pad configuration at board-level
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/mainboard/up/squared/bootblock.c:
https://review.coreboot.org/c/coreboot/+/49414/comment/2fd06538_5b6c3c2b
PS1, Line 6: #include "gpio.h"
This includes the whole big `gpio_table` just to garbage collect it
later... Why have the `early_gpio_table` in a separate file at all? it's
not that this one is growing too big, is it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49414
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0693a4419c58dde3c4536698940f03c30304b9d
Gerrit-Change-Number: 49414
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sat, 16 Jan 2021 13:46:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment