[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/common: Order the different types of cores based on APIC IDs

[Jan Samek (Code Review)]

Attention is currently required from: Subrata Banik, Paul Menzel, Sridhar Siricilla, Kyösti Mälkki, Elyes Haouas.

Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72132 )

Change subject: soc/intel/common: Order the different types of cores based on APIC IDs
......................................................................

Patch Set 18:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/72132/comment/7c5af373_9a3913b7 
PS18, Line 13: /sys/devices/system/cpu/cpu0/topology/thread_siblings_list:0-1
Sorry to ask a stupid question, but isn't just the first list unordered? After ordering it, the assignment of the HT siblings to each core is just the same before and after the patch.

I even verified this on my hardware - before the patch:
```
$ grep . /sys/devices/system/cpu/cpu*/topology/thread_siblings_list | sort -V
/sys/devices/system/cpu/cpu0/topology/thread_siblings_list:0-1                                                                                
/sys/devices/system/cpu/cpu1/topology/thread_siblings_list:0-1                                                                                
/sys/devices/system/cpu/cpu2/topology/thread_siblings_list:2-3                                                                                
/sys/devices/system/cpu/cpu3/topology/thread_siblings_list:2-3                                                                                
/sys/devices/system/cpu/cpu4/topology/thread_siblings_list:4-5                                                                                
/sys/devices/system/cpu/cpu5/topology/thread_siblings_list:4-5                                                                                
/sys/devices/system/cpu/cpu6/topology/thread_siblings_list:6-7                                                                                
/sys/devices/system/cpu/cpu7/topology/thread_siblings_list:6-7                                                                                
/sys/devices/system/cpu/cpu8/topology/thread_siblings_list:8-9                                                                                
/sys/devices/system/cpu/cpu9/topology/thread_siblings_list:8-9                                                                                
/sys/devices/system/cpu/cpu10/topology/thread_siblings_list:10-11                                                                             
/sys/devices/system/cpu/cpu11/topology/thread_siblings_list:10-11                                                                             
/sys/devices/system/cpu/cpu12/topology/thread_siblings_list:12                                                                                
/sys/devices/system/cpu/cpu13/topology/thread_siblings_list:13                                                                                
/sys/devices/system/cpu/cpu14/topology/thread_siblings_list:14                                                                                
/sys/devices/system/cpu/cpu15/topology/thread_siblings_list:15                                                                                
/sys/devices/system/cpu/cpu16/topology/thread_siblings_list:16                                                                                
/sys/devices/system/cpu/cpu17/topology/thread_siblings_list:17                                                                                
/sys/devices/system/cpu/cpu18/topology/thread_siblings_list:18                                                                                
/sys/devices/system/cpu/cpu19/topology/thread_siblings_list:19 
```

And after the patch:
```
$ grep . /sys/devices/system/cpu/cpu*/topology/thread_siblings_list | sort -V
/sys/devices/system/cpu/cpu0/topology/thread_siblings_list:0-1
/sys/devices/system/cpu/cpu1/topology/thread_siblings_list:0-1
/sys/devices/system/cpu/cpu2/topology/thread_siblings_list:2-3
/sys/devices/system/cpu/cpu3/topology/thread_siblings_list:2-3
/sys/devices/system/cpu/cpu4/topology/thread_siblings_list:4-5
/sys/devices/system/cpu/cpu5/topology/thread_siblings_list:4-5
/sys/devices/system/cpu/cpu6/topology/thread_siblings_list:6-7
/sys/devices/system/cpu/cpu7/topology/thread_siblings_list:6-7
/sys/devices/system/cpu/cpu8/topology/thread_siblings_list:8-9
/sys/devices/system/cpu/cpu9/topology/thread_siblings_list:8-9
/sys/devices/system/cpu/cpu10/topology/thread_siblings_list:10-11
/sys/devices/system/cpu/cpu11/topology/thread_siblings_list:10-11
/sys/devices/system/cpu/cpu12/topology/thread_siblings_list:12
/sys/devices/system/cpu/cpu13/topology/thread_siblings_list:13
/sys/devices/system/cpu/cpu14/topology/thread_siblings_list:14
/sys/devices/system/cpu/cpu15/topology/thread_siblings_list:15
/sys/devices/system/cpu/cpu16/topology/thread_siblings_list:16
/sys/devices/system/cpu/cpu17/topology/thread_siblings_list:17
/sys/devices/system/cpu/cpu18/topology/thread_siblings_list:18
/sys/devices/system/cpu/cpu19/topology/thread_siblings_list:19
```

At least I can tell, in both my and your case, the patch doesn't seem to break anything. Feel free to correct me, if I'm wrong there.

Used a vanilla Linux kernel v6.1.9 with Busybox v1.36.0 as a payload.