[coreboot-gerrit] Change in ...coreboot[master]: vboot: copy data structures to CBMEM for downstream use

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31329 )

Change subject: vboot: copy data structures to CBMEM for downstream use
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31329/3/src/security/vboot/common.c 
File src/security/vboot/common.c:

https://review.coreboot.org/#/c/31329/3/src/security/vboot/common.c@51 
PS3, Line 51: 	if (ENV_PRE_RAM)
> So, actually, this should be ENV_CACHE_AS_RAM after all, so that you'll still return the SRAM buffer […]

Sorry, I confused myself. ENV_CACHE_AS_RAM is always 0 for SRAM boards, which is of course not what I wanted. I wanted always 1.

Maybe we should add a new helper function somewhere to cover this case, something like preram_symbols_accessible() (true iff (!CACHE_AS_RAM || ENV_PRE_RAM)). Maybe just throw it in <symbols.h>.