[coreboot-gerrit] [S] Change in coreboot[master]: soc/amd/glinda: Use common fsp-s preloader

[Fred Reitberger (Code Review)]

Fred Reitberger has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71848 )

(

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: soc/amd/glinda: Use common fsp-s preloader
......................................................................

soc/amd/glinda: Use common fsp-s preloader

Use the common preloader for fsp-s

Signed-off-by: Fred Reitberger 
Change-Id: I32f8ca02c4de9e882f207c2dd2378b6b44dc61ff
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71848
Reviewed-by: Jason Glenesk 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/glinda/Kconfig
M src/soc/amd/glinda/Makefile.inc
D src/soc/amd/glinda/preload.c
3 files changed, 16 insertions(+), 14 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Jason Glenesk: Looks good to me, approved

diff --git a/src/soc/amd/glinda/Kconfig b/src/soc/amd/glinda/Kconfig
index f4f49b9..4db1193 100644
--- a/src/soc/amd/glinda/Kconfig
+++ b/src/soc/amd/glinda/Kconfig
@@ -72,6 +72,7 @@
    select SOC_AMD_COMMON_FSP_CCX_CPPC_HOB		# TODO: Check if this is still correct
    select SOC_AMD_COMMON_FSP_DMI_TABLES		# TODO: Check if this is still correct
    select SOC_AMD_COMMON_FSP_PCI			# TODO: Check if this is still correct
+	select SOC_AMD_COMMON_FSP_PRELOAD_FSPS
    select SSE2
    select UDK_2017_BINDING
    select USE_DDR5
diff --git a/src/soc/amd/glinda/Makefile.inc b/src/soc/amd/glinda/Makefile.inc
index 4d1ba55..76c6689 100644
--- a/src/soc/amd/glinda/Makefile.inc
+++ b/src/soc/amd/glinda/Makefile.inc
@@ -40,7 +40,6 @@
 ramstage-y	+= gpio.c
 ramstage-y	+= i2c.c
 ramstage-y	+= mca.c
-ramstage-y	+= preload.c
 ramstage-y	+= reset.c
 ramstage-y	+= root_complex.c
 ramstage-y	+= uart.c
diff --git a/src/soc/amd/glinda/preload.c b/src/soc/amd/glinda/preload.c
deleted file mode 100644
index 47f3580..0000000
--- a/src/soc/amd/glinda/preload.c
+++ /dev/null
@@ -1,13 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-/* TODO: Move to common? */
-
-#include <bootstate.h>
-#include <fsp/api.h>
-
-static void start_fsps_preload(void *unused)
-{
-	preload_fsps();
-}
-
-BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_ENTRY, start_fsps_preload, NULL);