Attention is currently required from: Lance Zhao, Konrad Adamczyk, Jakub Czapiga, Tim Wawrzynczak, Grzegorz Bernacki, Tim Van Patten.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74715 )
Change subject: acpi: Add missing cbfs_unmap()
......................................................................
Patch Set 3:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/74715/comment/1aea8913_01be9ffd
PS2, Line 1934: cbfs_unmap(dsdt_file);
This call doesn't actually free the memory. […]
For this change, we can cbfs_unmap(dsdt_file) after cbfs_unmap(slic_file) is done.
Beyond the scope of this change, I wonder if we can make mem_pool library flexible by freeing the buffer if it is in either last_alloc or second_to_last alloc.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74715
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf7ba6842f42404ad8bb415f8e7fda10403cbe2e
Gerrit-Change-Number: 74715
Gerrit-PatchSet: 3
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Konrad Adamczyk
konrada@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 15:42:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment