Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36667 )
Change subject: /mb/google/hatch/var/draini: Add new memory support
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36667/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36667/1//COMMIT_MSG@7
PS1, Line 7: draini
nit: dratini
https://review.coreboot.org/c/coreboot/+/36667/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/dratini/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36667/1/src/mainboard/google/hatch/...
PS1, Line 18: b0
maybe zero-pad these entries to the same length as the new entries?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36667
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic63d911458b59de11c12ce776f6f7d04b1eb3b6c
Gerrit-Change-Number: 36667
Gerrit-PatchSet: 1
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 13 Nov 2019 09:31:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment