Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31887 )
Change subject: vboot: make vboot workbuf available to payload ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/#/c/31887/5/payloads/libpayload/include/sysinfo.... File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/#/c/31887/5/payloads/libpayload/include/sysinfo.... PS5, Line 100: void *vb2_workbuf; Don't you need to store the size somewhere as well?
https://review.coreboot.org/#/c/31887/5/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/#/c/31887/5/src/lib/coreboot_table.c@212 PS5, Line 212: #if CONFIG(VBOOT) Do we still need this guard? Can we maybe get rid of it if we define some of the vboot_xxx() functions as empty stubs in the header when CONFIG_VBOOT is not enabled? (Compare how timestamp_get() is done in <timestamp.h>.)
https://review.coreboot.org/#/c/31887/5/src/lib/coreboot_table.c@560 PS5, Line 560: lb_vboot_handoff(head); Maybe keep this where it is because we want to get rid of it very soon anyway?