Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31837 )
Change subject: drivers/tpm: update TPM initialization logic for Intel FSP2.0
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31837/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31837/2//COMMIT_MSG@14
PS2, Line 14: TPM will be initialized whenever
: verstage is executed, depending on how the device is configured
I think I would prefer what Furquan said -- just don't support RECOVERY_MRC_CACHE with STARTS_IN_ROM […]
Correct. Even without any change, currently, it would do the memory retraining in recovery mode. You would see some extra error messages indicating failure to read hash, but probably not too bad.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31837
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ba91c275c33245be61041cb592e52f861dbafe6
Gerrit-Change-Number: 31837
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 13 Mar 2019 02:06:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment