Attention is currently required from: Bao Zheng, Jason Glenesk, Matt DeVillier, Zheng Bao, Martin Roth, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69470 )
Change subject: WIP:soc/amd/morgana: Move PSP FWs to 0x20000
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/amd/birman/Kconfig:
https://review.coreboot.org/c/coreboot/+/69470/comment/fd29e024_f694d346
PS2, Line 31: default 5
for chromeos we didn't use the first possible efs location (which is the soc default) so that it resides in the RO partition. for the non-chrome configuration we just use the default from the soc's kconfig
File src/mainboard/amd/birman/board.fmd:
https://review.coreboot.org/c/coreboot/+/69470/comment/7dc0ca23_40ad973f
PS2, Line 5: FMAP 3K
won't this result in a non erase block aligned cbfs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b1c7f9a7488a4d5ef94f21099692a23c3f8d27c
Gerrit-Change-Number: 69470
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 15 Nov 2022 12:40:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment