[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/xeon_sp: Use pre-processor to define ASL handler names

[Angel Pons (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu.

Angel Pons has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/82133?usp=email )

Change subject: soc/intel/xeon_sp: Use pre-processor to define ASL handler names
......................................................................

Patch Set 7:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/82133/comment/9fa64caa_8fb9d85b?usp... :
PS7, Line 16: As to the parameter count of the ASL handler, which is limited to
            : 8 by ACPI specification. It is encouraged to use up the Arg0-7
            : first. If the needed arguments exceed 8, the last Arg (Arg7)
            : could be passed as a package of more parameters, which could be
            : extracted into unused local variables in the ASL handler codes.
Does this have anything to do with the current change? I am confused by it.

File src/soc/intel/xeon_sp/acpi.c:

https://review.coreboot.org/c/coreboot/+/82133/comment/4012c84a_06cf4057?usp... :
PS7, Line 131: ASL_HANDLER_PATH(AH_PCIE_OSC)
I am pretty sure this should work, as string literals can be concatenated at compile time:

```suggestion
    acpigen_write_return_namestr("\_SB." TO_STR(AH_PCIE_OSC));
```

File src/soc/intel/xeon_sp/include/soc/asl_handler.h:

https://review.coreboot.org/c/coreboot/+/82133/comment/467dbb42_cb2ca3c6?usp... :
PS7, Line 6: #define TO_STR(name) #name
I think there's a macro for this somewhere in commonlib

https://review.coreboot.org/c/coreboot/+/82133/comment/ec01157c_8df579d2?usp... :
PS7, Line 11: #define AH_PCIE_OSC	H000
So, AIUI, is the idea to use monotonically increasing numbers for these macros? e.g. next macro would be `#define AH_FOO_BAR H001`?