Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31982 )
Change subject: {northbridge, soc, southbridge}/intel: Make use of pci_dev_set_subsystem()
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31982/1/src/northbridge/intel/fsp_rangeley/n...
File src/northbridge/intel/fsp_rangeley/northbridge.c:
https://review.coreboot.org/#/c/31982/1/src/northbridge/intel/fsp_rangeley/n...
PS1, Line 184:
We might want to copy this into pci_dev_set_subsystem() as I believe it is incorrect to set SSID to […]
i guess thats better option as 0000 is not valid one and we don't have check
https://review.coreboot.org/#/c/31982/1/src/soc/intel/baytrail/chip.c
File src/soc/intel/baytrail/chip.c:
https://review.coreboot.org/#/c/31982/1/src/soc/intel/baytrail/chip.c@76
PS1, Line 76: .set_subsystem = &pci_dev_set_subsystem,
You could drop that '&' as redundant, but don't bother fixing it here. […]
may be we can fix this in another CL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31982
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91982597fdf586ab514bec3d8e4d09f2565fe56d
Gerrit-Change-Number: 31982
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 Mar 2019 09:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment