Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43843 )
Change subject: soc/skylake: Enable SATA depending on devicetree configuration ......................................................................
Patch Set 4: Code-Review+2
(24 comments)
https://review.coreboot.org/c/coreboot/+/43843/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43843/4//COMMIT_MSG@7 PS4, Line 7: soc/skylake: Enable SATA depending on devicetree configuration soc/intel/skylake
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/51nb/x210/dev... File src/mainboard/51nb/x210/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/51nb/x210/dev... PS4, Line 149: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/asrock/h110m/... PS4, Line 289: device pci 17.0 on # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/facebook/mono... PS4, Line 261: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/eve/de... File src/mainboard/google/eve/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/eve/de... PS4, Line 351: device pci 17.0 off end # SATA SATA is disabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/fizz/v... File src/mainboard/google/fizz/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/fizz/v... PS4, Line 404: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/glados... File src/mainboard/google/glados/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/glados... PS4, Line 132: device pci 17.0 off end # SATA SATA is disabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/atlas/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... PS4, Line 329: device pci 17.0 off end # SATA SATA is disabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... PS4, Line 347: device pci 17.0 off end # SATA SATA is disabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/nami/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... PS4, Line 438: device pci 17.0 off end # SATA SATA is disabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/nautilus/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... PS4, Line 370: device pci 17.0 off end # SATA SATA is disabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/nocturne/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... PS4, Line 374: device pci 17.0 off end # SATA SATA is disabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/rammus/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... PS4, Line 333: device pci 17.0 off end # SATA SATA is disabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... File src/mainboard/google/poppy/variants/soraka/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/google/poppy/... PS4, Line 321: device pci 17.0 off end # SATA SATA is disabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/intel/kblrvp/... File src/mainboard/intel/kblrvp/variants/rvp11/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/intel/kblrvp/... PS4, Line 127: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/intel/kblrvp/... File src/mainboard/intel/kblrvp/variants/rvp7/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/intel/kblrvp/... PS4, Line 171: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/intel/kblrvp/... File src/mainboard/intel/kblrvp/variants/rvp8/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/intel/kblrvp/... PS4, Line 167: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/intel/saddleb... File src/mainboard/intel/saddlebrook/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/intel/saddleb... PS4, Line 242: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/libretrend/lt... File src/mainboard/libretrend/lt1000/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/libretrend/lt... PS4, Line 200: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/protectli/vau... File src/mainboard/protectli/vault_kbl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/protectli/vau... PS4, Line 252: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/purism/librem... PS4, Line 197: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/razer/blade_s... File src/mainboard/razer/blade_stealth_kbl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/razer/blade_s... PS4, Line 230: device pci 17.0 off end # SATA SATA is disabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43843/4/src/mainboard/supermicro/x1... PS4, Line 129: device pci 17.0 on end # SATA SATA is enabled
https://review.coreboot.org/c/coreboot/+/43843/4/src/soc/intel/skylake/chip.... File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/43843/4/src/soc/intel/skylake/chip.... PS4, Line 170: dev ? dev->enabled : 0 `dev && dev->enabled` is the canonical form to do this.