Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44343 )
Change subject: mb/google/zork: config ddi for dirinboz ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44343/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44343/1//COMMIT_MSG@7 PS1, Line 7: Add variant.c to align with dalboz reference board
What is the motivation behind doing this? Some of the changes in variant. […]
Hi Furquan, thank you for the comment. it looks we only need to config DDI setting for dirinboz.
https://review.coreboot.org/c/coreboot/+/44343/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/dirinboz/variant.c:
https://review.coreboot.org/c/coreboot/+/44343/1/src/mainboard/google/zork/v... PS1, Line 60: audio on older board versions
I don't think this applies to dirinboz. Entire code from line 12-line 105 should be dropped.
Done
https://review.coreboot.org/c/coreboot/+/44343/1/src/mainboard/google/zork/v... PS1, Line 117: board_sku == 0x5A80000C || board_sku == 0x5A800003 || board_sku == CROS_SKU_UNKNOWN
Zork is moving away from using SKU ID to FW_CONFIG. […]
removed, done.
https://review.coreboot.org/c/coreboot/+/44343/1/src/mainboard/google/zork/v... PS1, Line 205: (board_sku == 0x5A80000A) || (board_sku == 0x5A80000D) || (board_sku == 0x5A800001)
All these SKU IDs are specific to Dalboz. […]
removed, done. only config DDI to non HDMI for dirinboz.