Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32243 )
Change subject: mediatek/mt8183: add SAMSUNG and MICRON EMCP LPDDR4X support ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/32243/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32243/3//COMMIT_MSG@7 PS3, Line 7: support remove the trailing 'support'
https://review.coreboot.org/#/c/32243/3//COMMIT_MSG@7 PS3, Line 7: add support
https://review.coreboot.org/#/c/32243/3//COMMIT_MSG@9 PS3, Line 9: add change 'add something support' to 'support something'.
https://review.coreboot.org/#/c/32243/3//COMMIT_MSG@11 PS3, Line 11: Add a comment here to explain why the DQS is also changed, for example:
Also changed DQS starting offset to increase the scan range for RX window, which is required for Samsung EMCP DDR, and should not impact other existing memory modules.