Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30888 )
Change subject: sb/intel/i82801gx: Add a mb hook to override the SPI opmenu
......................................................................
Patch Set 1:
Patch Set 1:
It might be better to have flashrom deal with this properly.
How does coreboot handle it? AFAICS, the chips in question would
either have to be programmed byte-wise or need us to patch the
opmenu on the fly. I assume coreboot does the latter?
Coreboot indeed does the latter. This is not very mainboard specific, but more intel+SPI-flash specific, so IMO it does not really belong here, but could good-enough for now...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30888
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43e6abcc5c761720b31bc023016cb71b860e76ed
Gerrit-Change-Number: 30888
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Apr 2019 14:47:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment