Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45078 )
Change subject: soc/intel/elkhartlake: Update Kconfig ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG@10 PS4, Line 10: 1. use FSP2.1 instead of 2.2
EHL will still only support FSP2.1 because FSP2. […]
Please add that information to the commit message.
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG@17 PS4, Line 17: 8. update UART base address
I could do that but not prefer to as that would create 20+ patches just to update kconfig in mainboa […]
(Wouldn’t it be eight commits?)
Small commits are perfect for git and preferred in my opinion. You already have the git commit message summaries in the enumaration, and could add a short explanation if needed to each commit.
Small commits are preferred, because reverting and bisecting commits is much easier that way.
But I let others comment, and leave this as resolved.